Added ability to invite user as owner #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/hooks/api/ownerships.ts # src/i18n/nl.json # src/pages/organizers/[organizerId]/ownerships/index.page.tsx
# Conflicts: # src/hooks/api/ownerships.ts # src/i18n/nl.json # src/pages/organizers/[organizerId]/ownerships/index.page.tsx
simon-debruijn
previously requested changes
Nov 5, 2024
Anahkiasen
commented
Nov 18, 2024
| const ownershipId = error.body.detail.split('with id ')[1]; | ||
| await approveRequestedOwnership(ownershipId); | ||
| } else { | ||
| setError('email', { message: error.body.detail || error.title }); |
There was a problem hiding this comment.
@simon-debruijn I did this originally to cascade the email errors back to the user UI, but ended up reverting it to a generic since but it allowed users to probe for existing emails in the system, but now it's sometimes cryptic why an email is rejected. Do you think we should show the actual errors?
simon-debruijn
approved these changes
Nov 28, 2024
simon-debruijn
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Waiting for cultuurnet/udb3-backend#1847 to wrap up
Ticket: https://jira.publiq.be/browse/III-6358